Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'ewc_license' conditional check in stackstorm.yml example play #235

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Apr 6, 2019

Closes #237
Under some circumstances ewc_license could be None in stackstorm.yml Ansible play

Fixes:

fatal: [ubuntu16]: FAILED! => {"msg": "The conditional check 'ewc_license is defined and ewc_license | length > 0' failed. The error was: Unexpected templating type error occurred on ({% if ewc_license is defined and ewc_license | length > 0 %} True {% else %} False {% endif %}): object of type 'NoneType' has no len()\n\n"}

```
fatal: [ubuntu16]: FAILED! => {"msg": "The conditional check 'ewc_license is defined and ewc_license | length > 0' failed. The error was: Unexpected templating type error occurred on ({% if ewc_license is defined and ewc_license | length > 0 %} True {% else %} False {% endif %}): object of type 'NoneType' has no len()\n\n"}
```
@lingfish
Copy link
Contributor

lingfish commented Apr 7, 2019

Heh, I just did a PR for this as well. I believe that, if you guys have chosen to always set a default in vars, when the defined check is redundant.

@arm4b arm4b merged commit 72c96a7 into master Apr 8, 2019
@arm4b arm4b deleted the fix/ewc_license-conditional branch April 8, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants